diff options
author | Hou Tao <houtao1@huawei.com> | 2024-12-06 19:06:18 +0800 |
---|---|---|
committer | Alexei Starovoitov <ast@kernel.org> | 2024-12-06 09:14:26 -0800 |
commit | 27abc7b3fa2e09bbe41e2924d328121546865eda (patch) | |
tree | 2b8ce3d52f9501f2e5c338dd9b98da9019e809cc /Documentation | |
parent | 532d6b36b2bfac5514426a97a4df8d103d700d43 (diff) |
bpf: Fix exact match conditions in trie_get_next_key()
trie_get_next_key() uses node->prefixlen == key->prefixlen to identify
an exact match, However, it is incorrect because when the target key
doesn't fully match the found node (e.g., node->prefixlen != matchlen),
these two nodes may also have the same prefixlen. It will return
expected result when the passed key exist in the trie. However when a
recently-deleted key or nonexistent key is passed to
trie_get_next_key(), it may skip keys and return incorrect result.
Fix it by using node->prefixlen == matchlen to identify exact matches.
When the condition is true after the search, it also implies
node->prefixlen equals key->prefixlen, otherwise, the search would
return NULL instead.
Fixes: b471f2f1de8b ("bpf: implement MAP_GET_NEXT_KEY command for LPM_TRIE map")
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Hou Tao <houtao1@huawei.com>
Link: https://lore.kernel.org/r/20241206110622.1161752-6-houtao@huaweicloud.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions