diff options
author | Xiaomeng Tong <xiam0nd.tong@gmail.com> | 2022-03-27 16:10:02 +0800 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2022-04-05 10:24:48 +0100 |
commit | c8618d65007ba68d7891130642d73e89372101e8 (patch) | |
tree | 57597ed103d1eca0e2f0502a20c8555918ef8bc3 /Kbuild | |
parent | f730a46b931d894816af34a0ff8e4ad51565b39f (diff) |
ASoC: rt5682: fix an incorrect NULL check on list iterator
The bug is here:
if (!dai) {
The list iterator value 'dai' will *always* be set and non-NULL
by for_each_component_dais(), so it is incorrect to assume that
the iterator value will be NULL if the list is empty or no element
is found (In fact, it will be a bogus pointer to an invalid struct
object containing the HEAD). Otherwise it will bypass the check
'if (!dai) {' (never call dev_err() and never return -ENODEV;)
and lead to invalid memory access lately when calling
'rt5682_set_bclk1_ratio(dai, factor);'.
To fix the bug, just return rt5682_set_bclk1_ratio(dai, factor);
when found the 'dai', otherwise dev_err() and return -ENODEV;
Cc: stable@vger.kernel.org
Fixes: ebbfabc16d23d ("ASoC: rt5682: Add CCF usage for providing I2S clks")
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Link: https://lore.kernel.org/r/20220327081002.12684-1-xiam0nd.tong@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'Kbuild')
0 files changed, 0 insertions, 0 deletions