diff options
author | Kai Vehmanen <kai.vehmanen@linux.intel.com> | 2020-04-28 15:38:36 +0300 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2020-04-28 16:04:45 +0200 |
commit | ca76282b6faffc83601c25bd2a95f635c03503ef (patch) | |
tree | 80770ea91844f55d25b6fd4e29bd0375ae6d4703 /LICENSES/exceptions | |
parent | ef0b3203c758b6b8abdb5dca651880347eae6b8c (diff) |
ALSA: hda/hdmi: fix race in monitor detection during probe
A race exists between build_pcms() and build_controls() phases of codec
setup. Build_pcms() sets up notifier for jack events. If a monitor event
is received before build_controls() is run, the initial jack state is
lost and never reported via mixer controls.
The problem can be hit at least with SOF as the controller driver. SOF
calls snd_hda_codec_build_controls() in its workqueue-based probe and
this can be delayed enough to hit the race condition.
Fix the issue by invalidating the per-pin ELD information when
build_controls() is called. The existing call to hdmi_present_sense()
will update the ELD contents. This ensures initial monitor state is
correctly reflected via mixer controls.
BugLink: https://github.com/thesofproject/linux/issues/1687
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20200428123836.24512-1-kai.vehmanen@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'LICENSES/exceptions')
0 files changed, 0 insertions, 0 deletions