diff options
| author | Advait Dhamorikar <advaitdhamorikar@gmail.com> | 2024-10-05 15:04:36 +0530 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2024-10-14 23:45:37 +0530 |
| commit | 0aa4523cdb9683e35af91ebdfae8d2fb4e6c3b8b (patch) | |
| tree | 4ff4871531ab2fb320eef44f355ed8a539aca705 /drivers/dma | |
| parent | 662f045332addc961940e48eb920caa954abbf09 (diff) | |
dmaengine: ep93xx: Fix unsigned compared against 0
An unsigned value can never be negative,
so this test will always evaluate the same way.
In ep93xx_dma_alloc_chan_resources: An unsigned dma_cfg.port's
value is checked against EP93XX_DMA_I2S1 which is 0.
Signed-off-by: Advait Dhamorikar <advaitdhamorikar@gmail.com>
Link: https://lore.kernel.org/r/20241005093436.27728-1-advaitdhamorikar@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/ep93xx_dma.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c index 995427afe077..6d7f6bd12d76 100644 --- a/drivers/dma/ep93xx_dma.c +++ b/drivers/dma/ep93xx_dma.c @@ -929,8 +929,7 @@ static int ep93xx_dma_alloc_chan_resources(struct dma_chan *chan) /* Sanity check the channel parameters */ if (!edmac->edma->m2m) { - if (edmac->dma_cfg.port < EP93XX_DMA_I2S1 || - edmac->dma_cfg.port > EP93XX_DMA_IRDA) + if (edmac->dma_cfg.port > EP93XX_DMA_IRDA) return -EINVAL; if (edmac->dma_cfg.dir != ep93xx_dma_chan_direction(chan)) return -EINVAL; |