summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
diff options
context:
space:
mode:
authorLen Baker <len.baker@gmx.com>2021-09-04 17:41:06 +0200
committerAlex Deucher <alexander.deucher@amd.com>2021-09-07 13:30:50 -0400
commit67684fcbdd0ef60a52f15e74e0e8a85edc867ce4 (patch)
tree532110bcbcffff43b4f54ca44b74bda49b14c7ca /drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
parente8ba4922a2ed616125182f072eec2ec991da0341 (diff)
drm/radeon: Prefer kcalloc over open coded arithmetic
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors. So, refactor the code a bit to use the purpose specific kcalloc() function instead of the calculated size argument in the kzalloc() function. [1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments Signed-off-by: Len Baker <len.baker@gmx.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c')
0 files changed, 0 insertions, 0 deletions