diff options
| author | Su Sung Chung <Su.Chung@amd.com> | 2019-07-08 11:31:39 -0400 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2019-08-15 10:53:55 -0500 |
| commit | 91db9311945f01901ddb9813ce11364de214a156 (patch) | |
| tree | 1afec6692b3e5f2a29036ab0b889bf558adf91ac /drivers/gpu/drm/amd/display/dc/gpio/hw_generic.h | |
| parent | 37495fbdf12d1bce30dbc228c901ef45eba35739 (diff) | |
drm/amd/display: refactor gpio to allocate hw_container in constructor
[why]
if dynamic allocation fails during gpio_open, it will cause crash due to
page fault.
[how]
handle allocation when gpio object gets created and prevent from calling
gpio_open if allocation failed
Signed-off-by: Su Sung Chung <Su.Chung@amd.com>
Reviewed-by: Jun Lei <Jun.Lei@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/display/dc/gpio/hw_generic.h')
| -rw-r--r-- | drivers/gpu/drm/amd/display/dc/gpio/hw_generic.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_generic.h b/drivers/gpu/drm/amd/display/dc/gpio/hw_generic.h index 3ea1c13e3ea6..bd6ffeb5e9df 100644 --- a/drivers/gpu/drm/amd/display/dc/gpio/hw_generic.h +++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_generic.h @@ -27,6 +27,7 @@ #define __DAL_HW_generic_H__ #include "generic_regs.h" +#include "hw_gpio.h" struct hw_generic { struct hw_gpio base; @@ -38,9 +39,12 @@ struct hw_generic { #define HW_GENERIC_FROM_BASE(hw_gpio) \ container_of((HW_GPIO_FROM_BASE(hw_gpio)), struct hw_generic, base) -struct hw_gpio_pin *dal_hw_generic_create( +void dal_hw_generic_init( + struct hw_generic **hw_generic, struct dc_context *ctx, enum gpio_id id, uint32_t en); +struct hw_gpio_pin *dal_hw_generic_get_pin(struct gpio *gpio); + #endif |