diff options
| author | Dave Airlie <airlied@redhat.com> | 2017-09-29 14:34:38 +1000 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2017-09-29 13:02:28 -0400 |
| commit | 0e1c42fd181e7359be5c97655198551b6660f028 (patch) | |
| tree | b6a02e881b311c807f1f4ce9b77f0d3dcc4b037a /drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c | |
| parent | b08c3ca4e90d03b3a120f4e60dba4b2b5e087433 (diff) | |
amdgpu/dc: cleanup construct returns in gpio.
This is similiar to previous patches, don't return when we don't
need to, also do error checking before allocating memory, makes
it simpler to cleanup after.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c')
| -rw-r--r-- | drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c b/drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c index 4cdcdfb73e5c..660510842ecf 100644 --- a/drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c +++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c @@ -176,7 +176,7 @@ enum gpio_result dal_hw_gpio_config_mode( } } -bool dal_hw_gpio_construct( +void dal_hw_gpio_construct( struct hw_gpio *pin, enum gpio_id id, uint32_t en, @@ -194,8 +194,6 @@ bool dal_hw_gpio_construct( pin->store.mux = 0; pin->mux_supported = false; - - return true; } void dal_hw_gpio_destruct( |