diff options
| author | Jiri Kosina <jkosina@suse.cz> | 2022-03-23 09:58:40 +0100 | 
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2022-03-23 09:58:40 +0100 | 
| commit | b690490d6d466972ade172ee2e7f6ffa49e7e910 (patch) | |
| tree | 50a93da28c9128e19eb7a3038aecf75dab6b36e1 /drivers/iio/industrialio-buffer.c | |
| parent | f97ec5d75e9261a5da78dc28a8955b7cc0c4468b (diff) | |
| parent | 0f203948230720e849ad50d158adac1cd32c282f (diff) | |
Merge branch 'for-5.18/amd-sfh' into for-linus
- dead code elimination (Christophe JAILLET)
Diffstat (limited to 'drivers/iio/industrialio-buffer.c')
| -rw-r--r-- | drivers/iio/industrialio-buffer.c | 20 | 
1 files changed, 8 insertions, 12 deletions
diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c index e180728914c0..94eb9f6cf128 100644 --- a/drivers/iio/industrialio-buffer.c +++ b/drivers/iio/industrialio-buffer.c @@ -1727,8 +1727,7 @@ int iio_buffers_alloc_sysfs_and_mask(struct iio_dev *indio_dev)  	struct iio_dev_opaque *iio_dev_opaque = to_iio_dev_opaque(indio_dev);  	const struct iio_chan_spec *channels;  	struct iio_buffer *buffer; -	int unwind_idx; -	int ret, i; +	int ret, i, idx;  	size_t sz;  	channels = indio_dev->channels; @@ -1743,15 +1742,12 @@ int iio_buffers_alloc_sysfs_and_mask(struct iio_dev *indio_dev)  	if (!iio_dev_opaque->attached_buffers_cnt)  		return 0; -	for (i = 0; i < iio_dev_opaque->attached_buffers_cnt; i++) { -		buffer = iio_dev_opaque->attached_buffers[i]; -		ret = __iio_buffer_alloc_sysfs_and_mask(buffer, indio_dev, i); -		if (ret) { -			unwind_idx = i - 1; +	for (idx = 0; idx < iio_dev_opaque->attached_buffers_cnt; idx++) { +		buffer = iio_dev_opaque->attached_buffers[idx]; +		ret = __iio_buffer_alloc_sysfs_and_mask(buffer, indio_dev, idx); +		if (ret)  			goto error_unwind_sysfs_and_mask; -		}  	} -	unwind_idx = iio_dev_opaque->attached_buffers_cnt - 1;  	sz = sizeof(*(iio_dev_opaque->buffer_ioctl_handler));  	iio_dev_opaque->buffer_ioctl_handler = kzalloc(sz, GFP_KERNEL); @@ -1767,9 +1763,9 @@ int iio_buffers_alloc_sysfs_and_mask(struct iio_dev *indio_dev)  	return 0;  error_unwind_sysfs_and_mask: -	for (; unwind_idx >= 0; unwind_idx--) { -		buffer = iio_dev_opaque->attached_buffers[unwind_idx]; -		__iio_buffer_free_sysfs_and_mask(buffer, indio_dev, unwind_idx); +	while (idx--) { +		buffer = iio_dev_opaque->attached_buffers[idx]; +		__iio_buffer_free_sysfs_and_mask(buffer, indio_dev, idx);  	}  	return ret;  }  | 
