diff options
author | Maxime Ripard <maxime@cerno.tech> | 2022-03-31 16:37:43 +0200 |
---|---|---|
committer | Maxime Ripard <maxime@cerno.tech> | 2022-04-06 15:18:01 +0200 |
commit | d65661ace1880d6c0d4a34770c7b0d54e7675534 (patch) | |
tree | abcae9e9c6674a2cb680322f18df9b14f0fa0671 /drivers/message | |
parent | 4dfcaa09164eabe7c141e74c7bc34add0fea360c (diff) |
drm/vc4: kms: Ignore atomic_flush if we're disabled
atomic_flush will be called for each CRTC even if they aren't enabled.
The whole code we have there will thus run without a properly affected
channel, which can then result in all sorts of weird behaviour.
Fortunately, the DRM_PLANE_COMMIT_ACTIVE_ONLY flag will skip the CRTC
atomic_begin and atomic_flush, and the planes atomic_update, if they
aren't enabled.
Our plane atomic_update is a nop, and atomic_begin will copy the current
HVS channel to the vc4_crtc structure for the interrupt handler to
consume, but the handler won't run if the CRTC is disabled. So in the
end, it will only skip our CRTC atomic_flush, which is what we want.
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20220331143744.777652-7-maxime@cerno.tech
Diffstat (limited to 'drivers/message')
0 files changed, 0 insertions, 0 deletions