summaryrefslogtreecommitdiff
path: root/drivers/net/netdevsim/psample.c
diff options
context:
space:
mode:
authorMatthieu Baerts <matthieu.baerts@tessares.net>2023-04-11 22:42:12 +0200
committerJakub Kicinski <kuba@kernel.org>2023-04-13 09:58:55 -0700
commit711ae788cbbb82818531b55e32b09518ee09a11a (patch)
tree03c80239fbb5bde319ee672781d86361eae84adb /drivers/net/netdevsim/psample.c
parentc0ff6f6da66a7791a32c0234388b1bdc00244917 (diff)
selftests: mptcp: userspace pm: uniform verify events
Simply adding a "sleep" before checking something is usually not a good idea because the time that has been picked can not be enough or too much. The best is to wait for events with a timeout. In this selftest, 'sleep 0.5' is used more than 40 times. It is always used before calling a 'verify_*' function except for this verify_listener_events which has been added later. At the end, using all these 'sleep 0.5' seems to work: the slow CIs don't complain so far. Also because it doesn't take too much time, we can just add two more 'sleep 0.5' to uniform what is done before calling a 'verify_*' function. For the same reasons, we can also delay a bigger refactoring to replace all these 'sleep 0.5' by functions waiting for events instead of waiting for a fix time and hope for the best. Fixes: 6c73008aa301 ("selftests: mptcp: listener test for userspace PM") Cc: stable@vger.kernel.org Suggested-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/netdevsim/psample.c')
0 files changed, 0 insertions, 0 deletions