diff options
| author | Peter Geis <pgwipeout@gmail.com> | 2021-05-29 07:05:55 -0400 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-05-30 14:24:38 -0700 |
| commit | 546d6bad18c04926c4d0eba4222654a9a60ea830 (patch) | |
| tree | 3226c42f9b2beb73d39d20324753a724b6352fb5 /drivers/net/phy/motorcomm.c | |
| parent | 8b97f36aa5ab1dff6087392c03c28266a466fe79 (diff) | |
net: phy: fix yt8511 clang uninitialized variable warning
clang doesn't preinitialize variables. If phy_select_page failed and
returned an error, phy_restore_page would be called with `ret` being
uninitialized.
Even though phy_restore_page won't use `ret` in this scenario,
initialize `ret` to silence the warning.
Fixes: 48e8c6f1612b ("net: phy: add driver for Motorcomm yt8511 phy")
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/phy/motorcomm.c')
| -rw-r--r-- | drivers/net/phy/motorcomm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c index 796b68f4b499..68cd19540c67 100644 --- a/drivers/net/phy/motorcomm.c +++ b/drivers/net/phy/motorcomm.c @@ -50,8 +50,8 @@ static int yt8511_write_page(struct phy_device *phydev, int page) static int yt8511_config_init(struct phy_device *phydev) { + int oldpage, ret = 0; unsigned int ge, fe; - int ret, oldpage; /* set clock mode to 125mhz */ oldpage = phy_select_page(phydev, YT8511_EXT_CLK_GATE); |