diff options
| author | Felix Fietkau <nbd@nbd.name> | 2024-09-17 13:09:42 +0200 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2024-09-18 16:34:00 +0300 |
| commit | 34b69548108480ebb36cb6a067974a88ec745897 (patch) | |
| tree | 79352b123c446db4708d337fe4a104e9aa6a26da /drivers/net/wireless/intel/iwlegacy/common.c | |
| parent | 5575058ba95bb016243e54e5ca3371b9884ded56 (diff) | |
wifi: mt76: do not increase mcu skb refcount if retry is not supported
If mcu_skb_prepare_msg is not implemented, incrementing skb refcount does not
work for mcu message retry. In some cases (e.g. on SDIO), shared skbs can trigger
a BUG_ON, crashing the system.
Fix this by only incrementing refcount if retry is actually supported.
Fixes: 3688c18b65ae ("wifi: mt76: mt7915: retry mcu messages")
Closes: https://lore.kernel.org/r/d907b13a-f8be-4cb8-a0bb-560a21278041@notapiano/
Reported-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> #KernelCI
Tested-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20240917110942.22077-1-nbd@nbd.name
Diffstat (limited to 'drivers/net/wireless/intel/iwlegacy/common.c')
0 files changed, 0 insertions, 0 deletions