summaryrefslogtreecommitdiff
path: root/drivers/pci/controller/pcie-rcar.c
diff options
context:
space:
mode:
authorNiklas Cassel <cassel@kernel.org>2024-03-07 12:15:20 +0100
committerKrzysztof Wilczyński <kwilczynski@kernel.org>2024-03-10 18:51:01 +0000
commit72e34b8593e08a0ee759b7a038e0b178418ea6f8 (patch)
tree5dc48dda0d51f41257541b4c1eb8ab4556884736 /drivers/pci/controller/pcie-rcar.c
parentf3a296405b6e65fe478144c2f85602dc5668700c (diff)
PCI: dwc: endpoint: Fix advertised resizable BAR size
The commit message in commit fc9a77040b04 ("PCI: designware-ep: Configure Resizable BAR cap to advertise the smallest size") claims that it modifies the Resizable BAR capability to only advertise support for 1 MB size BARs. However, the commit writes all zeroes to PCI_REBAR_CAP (the register which contains the possible BAR sizes that a BAR be resized to). According to the spec, it is illegal to not have a bit set in PCI_REBAR_CAP, and 1 MB is the smallest size allowed. Set bit 4 in PCI_REBAR_CAP, so that we actually advertise support for a 1 MB BAR size. Before: Capabilities: [2e8 v1] Physical Resizable BAR BAR 0: current size: 1MB BAR 1: current size: 1MB BAR 2: current size: 1MB BAR 3: current size: 1MB BAR 4: current size: 1MB BAR 5: current size: 1MB After: Capabilities: [2e8 v1] Physical Resizable BAR BAR 0: current size: 1MB, supported: 1MB BAR 1: current size: 1MB, supported: 1MB BAR 2: current size: 1MB, supported: 1MB BAR 3: current size: 1MB, supported: 1MB BAR 4: current size: 1MB, supported: 1MB BAR 5: current size: 1MB, supported: 1MB Fixes: fc9a77040b04 ("PCI: designware-ep: Configure Resizable BAR cap to advertise the smallest size") Link: https://lore.kernel.org/linux-pci/20240307111520.3303774-1-cassel@kernel.org Signed-off-by: Niklas Cassel <cassel@kernel.org> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Cc: <stable@vger.kernel.org> # 5.2
Diffstat (limited to 'drivers/pci/controller/pcie-rcar.c')
0 files changed, 0 insertions, 0 deletions