diff options
| author | Alex Williamson <alex.williamson@redhat.com> | 2021-11-08 11:03:57 -0700 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2021-11-16 10:56:53 +0100 |
| commit | 812fcc609502096e98cc3918a4b807722dba8fd9 (patch) | |
| tree | e33425a79656bebbf652cfc099e3fbfcdeb8bcfe /drivers/platform/x86/thinkpad_acpi.c | |
| parent | 0f07c023dcd08ca49b6d3dd018abc7cd56301478 (diff) | |
platform/x86: think-lmi: Abort probe on analyze failure
A Lenovo ThinkStation S20 (4157CTO BIOS 60KT41AUS) fails to boot on
recent kernels including the think-lmi driver, due to the fact that
errors returned by the tlmi_analyze() function are ignored by
tlmi_probe(), where tlmi_sysfs_init() is called unconditionally.
This results in making use of an array of already freed, non-null
pointers and other uninitialized globals, causing all sorts of nasty
kobject and memory faults.
Make use of the analyze function return value, free a couple leaked
allocations, and remove the settings_count field, which is incremented
but never consumed.
Fixes: a40cd7ef22fb ("platform/x86: think-lmi: Add WMI interface support on Lenovo platforms")
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Reviewed-by: Mark Gross <markgross@kernel.org>
Reviewed-by: Mark Pearson <markpearson@lenovo.com>
Link: https://lore.kernel.org/r/163639463588.1330483.15850167112490200219.stgit@omen
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/x86/thinkpad_acpi.c')
0 files changed, 0 insertions, 0 deletions