diff options
| author | Mark Brown <broonie@sirena.org.uk> | 2013-04-28 02:13:37 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@sirena.org.uk> | 2013-04-28 02:13:37 +0100 |
| commit | 0e340ce1ddcf41ca435ef695ef004a6f587c749e (patch) | |
| tree | 9f4cc87138ecf29762e1037a8c028c6ddd3ebc03 /drivers/regulator/core.c | |
| parent | 97844ede9487fc7c4689ce1499bbaa10312618be (diff) | |
| parent | 020501f1a0911af70873e4d3d122b2e1889ccd03 (diff) | |
Merge remote-tracking branch 'regulator/topic/core' into v3.9-rc8
Diffstat (limited to 'drivers/regulator/core.c')
| -rw-r--r-- | drivers/regulator/core.c | 23 |
1 files changed, 20 insertions, 3 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 56f4ca0854c9..6437949849b0 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -116,7 +116,7 @@ static const char *rdev_get_name(struct regulator_dev *rdev) * @supply: regulator supply name * * Extract the regulator device node corresponding to the supply name. - * retruns the device node corresponding to the regulator if found, else + * returns the device node corresponding to the regulator if found, else * returns NULL. */ static struct device_node *of_get_regulator(struct device *dev, const char *supply) @@ -1229,7 +1229,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id, struct regulator_dev *rdev; struct regulator *regulator = ERR_PTR(-EPROBE_DEFER); const char *devname = NULL; - int ret; + int ret = 0; if (id == NULL) { pr_err("get() with no identifier\n"); @@ -1245,6 +1245,15 @@ static struct regulator *_regulator_get(struct device *dev, const char *id, if (rdev) goto found; + /* + * If we have return value from dev_lookup fail, we do not expect to + * succeed, so, quit with appropriate error value + */ + if (ret) { + regulator = ERR_PTR(ret); + goto out; + } + if (board_wants_dummy_regulator) { rdev = dummy_regulator_rdev; goto found; @@ -3512,7 +3521,14 @@ regulator_register(const struct regulator_desc *regulator_desc, r = regulator_dev_lookup(dev, supply, &ret); - if (!r) { + if (ret == -ENODEV) { + /* + * No supply was specified for this regulator and + * there will never be one. + */ + ret = 0; + goto add_dev; + } else if (!r) { dev_err(dev, "Failed to find supply %s\n", supply); ret = -EPROBE_DEFER; goto scrub; @@ -3530,6 +3546,7 @@ regulator_register(const struct regulator_desc *regulator_desc, } } +add_dev: /* add consumers devices */ if (init_data) { for (i = 0; i < init_data->num_consumer_supplies; i++) { |