diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2019-10-31 13:53:41 +0300 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2019-10-31 11:40:57 -0600 |
commit | 41591a51f00d2dc7bb9dc6e9bedf56c5cf6f2392 (patch) | |
tree | ab2f925a8b59d0ac98b77a1c763e5649afa37241 /drivers | |
parent | 6873e0bd6a9cb14ecfadd89d9ed9698ff1761902 (diff) |
iocost: don't nest spin_lock_irq in ioc_weight_write()
This code causes a static analysis warning:
block/blk-iocost.c:2113 ioc_weight_write() error: double lock 'irq'
We disable IRQs in blkg_conf_prep() and re-enable them in
blkg_conf_finish(). IRQ disable/enable should not be nested because
that means the IRQs will be enabled at the first unlock instead of the
second one.
Fixes: 7caa47151ab2 ("blkcg: implement blk-iocost")
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers')
0 files changed, 0 insertions, 0 deletions