summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorXie Yongji <xieyongji@bytedance.com>2021-10-26 22:40:14 +0800
committerJens Axboe <axboe@kernel.dk>2021-10-27 14:15:54 -0600
commitaf3c570fb0df422b4906ebd11c1bf363d89961d5 (patch)
tree7f6947d1b6297ec4e89177460195bdf831646c2f /drivers
parentc4318d6cd038472d13e08a54a9035863c8c160bd (diff)
loop: Use blk_validate_block_size() to validate block size
Remove loop_validate_block_size() and use the block layer helper to validate block size. Signed-off-by: Xie Yongji <xieyongji@bytedance.com> Link: https://lore.kernel.org/r/20211026144015.188-4-xieyongji@bytedance.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/block/loop.c17
1 files changed, 2 insertions, 15 deletions
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 980b538c008a..ab23bbc467e7 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -273,19 +273,6 @@ static void __loop_update_dio(struct loop_device *lo, bool dio)
}
/**
- * loop_validate_block_size() - validates the passed in block size
- * @bsize: size to validate
- */
-static int
-loop_validate_block_size(unsigned short bsize)
-{
- if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize))
- return -EINVAL;
-
- return 0;
-}
-
-/**
* loop_set_size() - sets device size and notifies userspace
* @lo: struct loop_device to set the size for
* @size: new size of the loop device
@@ -1236,7 +1223,7 @@ static int loop_configure(struct loop_device *lo, fmode_t mode,
}
if (config->block_size) {
- error = loop_validate_block_size(config->block_size);
+ error = blk_validate_block_size(config->block_size);
if (error)
goto out_unlock;
}
@@ -1752,7 +1739,7 @@ static int loop_set_block_size(struct loop_device *lo, unsigned long arg)
if (lo->lo_state != Lo_bound)
return -ENXIO;
- err = loop_validate_block_size(arg);
+ err = blk_validate_block_size(arg);
if (err)
return err;