diff options
| author | David Howells <dhowells@redhat.com> | 2024-01-17 15:49:26 +0000 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2024-01-22 22:30:38 +0000 |
| commit | b90493505347a4ca4d900f317e2b330e0e43ae2f (patch) | |
| tree | 8ba13e144f0090ab12ab7993a60c2e441055dae9 /fs/afs/proc.c | |
| parent | cfcc005dbcc79f1e6bddc6fd4b3e8a1163a6d181 (diff) | |
afs: Fix missing/incorrect unlocking of RCU read lock
In afs_proc_addr_prefs_show(), we need to unlock the RCU read lock in both
places before returning (and not lock it again).
Fixes: f94f70d39cc2 ("afs: Provide a way to configure address priorities")
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202401172243.cd53d5f6-oliver.sang@intel.com
Signed-off-by: David Howells <dhowells@redhat.com>
cc: linux-afs@lists.infradead.org
cc: linux-fsdevel@vger.kernel.org
Diffstat (limited to 'fs/afs/proc.c')
| -rw-r--r-- | fs/afs/proc.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/afs/proc.c b/fs/afs/proc.c index 3bd02571f30d..15eab053af6d 100644 --- a/fs/afs/proc.c +++ b/fs/afs/proc.c @@ -166,7 +166,7 @@ static int afs_proc_addr_prefs_show(struct seq_file *m, void *v) if (!preflist) { seq_puts(m, "NO PREFS\n"); - return 0; + goto out; } seq_printf(m, "PROT SUBNET PRIOR (v=%u n=%u/%u/%u)\n", @@ -191,7 +191,8 @@ static int afs_proc_addr_prefs_show(struct seq_file *m, void *v) } } - rcu_read_lock(); +out: + rcu_read_unlock(); return 0; } |