diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2022-10-31 16:13:05 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:09:29 -0400 |
| commit | b17d3cec14b487924df709dbeffb900f124a2607 (patch) | |
| tree | e3a5ce061e8e294d8d0570a7916996cebefb9d8d /fs/bcachefs/sysfs.c | |
| parent | 5f417394033a0d8bfb31d02b3becf7381dc13867 (diff) | |
bcachefs: Run btree updates after write out of write_point
In the write path, after the write to the block device(s) complete we
have to punt to process context to do the btree update.
Instead of using the work item embedded in op->cl, this patch switches
to a per write-point work item. This helps with two different issues:
- lock contention: btree updates to the same writepoint will (usually)
be updating the same alloc keys
- context switch overhead: when we're bottlenecked on btree updates,
having a thread (running out of a work item) checking the write point
for completed ops is cheaper than queueing up a new work item and
waking up a kworker.
In an arbitrary benchmark, 4k random writes with fio running inside a
VM, this patch resulted in a 10% improvement in total iops.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/sysfs.c')
| -rw-r--r-- | fs/bcachefs/sysfs.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/bcachefs/sysfs.c b/fs/bcachefs/sysfs.c index 7e10adba5c75..ec672134cb18 100644 --- a/fs/bcachefs/sysfs.c +++ b/fs/bcachefs/sysfs.c @@ -180,6 +180,7 @@ read_attribute(btree_key_cache); read_attribute(btree_transactions); read_attribute(stripes_heap); read_attribute(open_buckets); +read_attribute(write_points); read_attribute(internal_uuid); @@ -418,6 +419,9 @@ SHOW(bch2_fs) if (attr == &sysfs_open_buckets) bch2_open_buckets_to_text(out, c); + if (attr == &sysfs_write_points) + bch2_write_points_to_text(out, c); + if (attr == &sysfs_compression_stats) bch2_compression_stats_to_text(out, c); @@ -563,6 +567,7 @@ struct attribute *bch2_fs_internal_files[] = { &sysfs_new_stripes, &sysfs_stripes_heap, &sysfs_open_buckets, + &sysfs_write_points, &sysfs_io_timers_read, &sysfs_io_timers_write, |