diff options
author | Josef Bacik <josef@toxicpanda.com> | 2021-05-19 10:52:45 -0400 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2021-05-27 23:30:49 +0200 |
commit | b86652be7c83f70bf406bed18ecf55adb9bfb91b (patch) | |
tree | a9b2a386d63c91761f4aecff6239b196f7c58f57 /fs/btrfs/extent-tree.c | |
parent | 4c80a97d7b02cf68e169118ef2bda0725fc87f6f (diff) |
btrfs: fix error handling in btrfs_del_csums
Error injection stress would sometimes fail with checksums on disk that
did not have a corresponding extent. This occurred because the pattern
in btrfs_del_csums was
while (1) {
ret = btrfs_search_slot();
if (ret < 0)
break;
}
ret = 0;
out:
btrfs_free_path(path);
return ret;
If we got an error from btrfs_search_slot we'd clear the error because
we were breaking instead of goto out. Instead of using goto out, simply
handle the cases where we may leave a random value in ret, and get rid
of the
ret = 0;
out:
pattern and simply allow break to have the proper error reporting. With
this fix we properly abort the transaction and do not commit thinking we
successfully deleted the csum.
Reviewed-by: Qu Wenruo <wqu@suse.com>
CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/extent-tree.c')
0 files changed, 0 insertions, 0 deletions