diff options
| author | David Disseldorp <ddiss@suse.de> | 2023-12-08 11:41:56 +1100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-12-15 23:01:04 +0100 |
| commit | 2b0122aaa800b021e36027d7f29e206f87c761d6 (patch) | |
| tree | b1b4c9277eca4f91acde5da09223768c548b8729 /fs/btrfs | |
| parent | 6140ba8a0a1460986ee98b4062df7d4876b88295 (diff) | |
btrfs: sysfs: validate scrub_speed_max value
The value set as scrub_speed_max accepts size with suffixes
(k/m/g/t/p/e) but we should still validate it for trailing characters,
similar to what we do with chunk_size_store.
CC: stable@vger.kernel.org # 5.15+
Signed-off-by: David Disseldorp <ddiss@suse.de>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/sysfs.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index e6b51fb3ddc1..84c05246ffd8 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -1783,6 +1783,10 @@ static ssize_t btrfs_devinfo_scrub_speed_max_store(struct kobject *kobj, unsigned long long limit; limit = memparse(buf, &endptr); + /* There could be trailing '\n', also catch any typos after the value. */ + endptr = skip_spaces(endptr); + if (*endptr != 0) + return -EINVAL; WRITE_ONCE(device->scrub_speed_max, limit); return len; } |