diff options
| author | Andreas Gruenbacher <agruenba@redhat.com> | 2024-06-10 23:26:36 +0200 |
|---|---|---|
| committer | Andreas Gruenbacher <agruenba@redhat.com> | 2024-06-20 16:38:15 +0200 |
| commit | 5a1906a476bc84145f20cd1941aa1250d38db4aa (patch) | |
| tree | 9cbebc2286dd55711d4bbeb22b0207c26d3c5a70 /fs/gfs2 | |
| parent | d9a75a60699dedaac17d2b5170bb2e3cdc03481e (diff) | |
gfs2: Revert "check for no eligible quota changes"
Since the previous commit, function gfs2_quota_sync() will not cause the
sync generation to creep forward by one every time the function is
called; this helps keep things a but more tidy. We also don't care that
this function allocates a page of memory every time it is called, so no
good reason for keeping qd_changed() anymore, which just duplicates
qd_grab_sync().
This reverts commit 06aa6fd31a5f402b055e12ea53bb7b086359d3c8.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'fs/gfs2')
| -rw-r--r-- | fs/gfs2/quota.c | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 4f2caa06ca93..2e6bc77f4f81 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -1308,24 +1308,6 @@ void gfs2_quota_change(struct gfs2_inode *ip, s64 change, } } -static bool qd_changed(struct gfs2_sbd *sdp) -{ - struct gfs2_quota_data *qd; - bool changed = false; - - spin_lock(&qd_lock); - list_for_each_entry(qd, &sdp->sd_quota_list, qd_list) { - spin_lock(&qd->qd_lockref.lock); - changed = !test_bit(QDF_LOCKED, &qd->qd_flags) && - test_bit(QDF_CHANGE, &qd->qd_flags); - spin_unlock(&qd->qd_lockref.lock); - if (changed) - break; - } - spin_unlock(&qd_lock); - return changed; -} - int gfs2_quota_sync(struct super_block *sb, int type) { struct gfs2_sbd *sdp = sb->s_fs_info; @@ -1336,8 +1318,6 @@ int gfs2_quota_sync(struct super_block *sb, int type) if (sb_rdonly(sdp->sd_vfs)) return 0; - if (!qd_changed(sdp)) - return 0; qda = kcalloc(max_qd, sizeof(struct gfs2_quota_data *), GFP_KERNEL); if (!qda) |