summaryrefslogtreecommitdiff
path: root/fs/orangefs
diff options
context:
space:
mode:
authorSteve French <stfrench@microsoft.com>2023-05-09 01:00:42 -0500
committerSteve French <stfrench@microsoft.com>2023-05-09 09:53:59 -0500
commit2cb6f968775a9fd60c90a6042b9550bcec3ea087 (patch)
tree10f0f2bbe212d6ffc46d45db749d6c01c802be27 /fs/orangefs
parentba8c2b75b02a162202d31e6200ab15da1035a7d0 (diff)
SMB3: force unmount was failing to close deferred close files
In investigating a failure with xfstest generic/392 it was noticed that mounts were reusing a superblock that should already have been freed. This turned out to be related to deferred close files keeping a reference count until the closetimeo expired. Currently the only way an fs knows that mount is beginning is when force unmount is called, but when this, ie umount_begin(), is called all deferred close files on the share (tree connection) should be closed immediately (unless shared by another mount) to avoid using excess resources on the server and to avoid reusing a superblock which should already be freed. In umount_begin, close all deferred close handles for that share if this is the last mount using that share on this client (ie send the SMB3 close request over the wire for those that have been already closed by the app but that we have kept a handle lease open for and have not sent closes to the server for yet). Reported-by: David Howells <dhowells@redhat.com> Acked-by: Bharath SM <bharathsm@microsoft.com> Cc: <stable@vger.kernel.org> Fixes: 78c09634f7dc ("Cifs: Fix kernel oops caused by deferred close for files.") Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/orangefs')
0 files changed, 0 insertions, 0 deletions