diff options
author | Omar Sandoval <osandov@fb.com> | 2016-09-17 01:28:26 -0700 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2016-09-17 08:39:16 -0600 |
commit | 05fd095d53b979878f016c3a7080d3683cc89d72 (patch) | |
tree | 93751c669d2cba783d4762127efa949ad4bda5f9 /fs | |
parent | 98d95416dbfaf4910caadfb4ddc75e4aacbdff8c (diff) |
sbitmap: re-initialize allocation hints after resize
After a struct sbitmap_queue is resized smaller, the allocation hints
may still be set to bits beyond the new depth of the bitmap. This means
that, for example, if the number of blk-mq tags is reduced through
sysfs, more requests than the nominal queue depth may be in flight.
It's tempting to fix this at resize time by doing a one-time
reinitialization of the hints, but this can race with
__sbitmap_queue_get() updating the hint. Instead, check the hint before
we use it. This caused no measurable performance difference in my
synthetic benchmarks.
Signed-off-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions