summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorJingbo Xu <jefflexu@linux.alibaba.com>2023-02-09 14:39:12 +0800
committerGao Xiang <hsiangkao@linux.alibaba.com>2023-02-15 08:11:27 +0800
commit7032809a44d752b9e2275833787e0aa88a7540af (patch)
treeeebf55ab84c629a2f256764c277cd0b4e500246a /fs
parent2dfb8c3b122fad4504a92c34ba68f2fe4444b3f6 (diff)
erofs: relinquish volume with mutex held
Relinquish fscache volume with mutex held. Otherwise if a new domain is registered when the old domain with the same name gets removed from the list but not relinquished yet, fscache may complain the collision. Fixes: 8b7adf1dff3d ("erofs: introduce fscache-based domain") Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com> Reviewed-by: Jia Zhu <zhujia.zj@bytedance.com> Link: https://lore.kernel.org/r/20230209063913.46341-4-jefflexu@linux.alibaba.com Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/erofs/fscache.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index 0ee08e51c4a6..9383afe09bd0 100644
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -326,8 +326,8 @@ static void erofs_fscache_domain_put(struct erofs_domain *domain)
kern_unmount(erofs_pseudo_mnt);
erofs_pseudo_mnt = NULL;
}
- mutex_unlock(&erofs_domain_list_lock);
fscache_relinquish_volume(domain->volume, NULL, false);
+ mutex_unlock(&erofs_domain_list_lock);
kfree(domain->domain_id);
kfree(domain);
return;