diff options
| author | Dan Carpenter <error27@gmail.com> | 2023-01-17 17:17:29 +0300 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2023-01-18 17:49:48 +0100 |
| commit | 81c254a65ceb2770bc3cd87bd172a29d8ae92dc4 (patch) | |
| tree | 9fa190159e2183867072750dceca7852abd9c4de /include/sound | |
| parent | 3ee0fe7fa39b14d1cea455b7041f2df933bd97d2 (diff) | |
ALSA: fireface: fix locking bug in ff400_copy_msg_to_user()
The ff400_copy_msg_to_user() function drops the spin lock to call
copy_to_user(). However, if the copy_to_user() fails, then it must
take the lock again before returning. Failure to take the lock leads
to a double unlock in the caller, hwdep_read().
Fixes: acdebd8b4c0c ("ALSA: fireface: implement message parser for Fireface 400")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/Y8at+W/7OGvEBY8O@kili
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'include/sound')
0 files changed, 0 insertions, 0 deletions