diff options
| author | Sabrina Dubroca <sd@queasysnail.net> | 2022-08-17 14:54:36 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-08-19 16:50:36 -0700 |
| commit | e82c649e851c9c25367fb7a2a6cf3479187de467 (patch) | |
| tree | 6853ae0db1837ee3c7ba4a6df816c607f92e9a3b /kernel/scftorture.c | |
| parent | 9dbdfd4a9f3416c84d22623e6b5bfe1966e336b7 (diff) | |
Revert "net: macsec: update SCI upon MAC address change."
This reverts commit 6fc498bc82929ee23aa2f35a828c6178dfd3f823.
Commit 6fc498bc8292 states:
SCI should be updated, because it contains MAC in its first 6
octets.
That's not entirely correct. The SCI can be based on the MAC address,
but doesn't have to be. We can also use any 64-bit number as the
SCI. When the SCI based on the MAC address, it uses a 16-bit "port
number" provided by userspace, which commit 6fc498bc8292 overwrites
with 1.
In addition, changing the SCI after macsec has been setup can just
confuse the receiver. If we configure the RXSC on the peer based on
the original SCI, we should keep the same SCI on TX.
When the macsec device is being managed by a userspace key negotiation
daemon such as wpa_supplicant, commit 6fc498bc8292 would also
overwrite the SCI defined by userspace.
Fixes: 6fc498bc8292 ("net: macsec: update SCI upon MAC address change.")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Link: https://lore.kernel.org/r/9b1a9d28327e7eb54550a92eebda45d25e54dd0d.1660667033.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'kernel/scftorture.c')
0 files changed, 0 insertions, 0 deletions