diff options
| author | Naohiro Aota <naohiro.aota@wdc.com> | 2021-03-24 23:23:11 +0900 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2021-04-19 17:25:17 +0200 |
| commit | e75f9fd194090e69c5ffd856ba89160683d343da (patch) | |
| tree | 05b633aa7269268f347323cd9f07303abc2a2231 /lib/test_bits.c | |
| parent | 2cdb3909c9e95879b6fa63a49caaa3b8824f1cb8 (diff) | |
btrfs: zoned: move log tree node allocation out of log_root_tree->log_mutex
Commit 6e37d2459941 ("btrfs: zoned: fix deadlock on log sync") pointed out
a deadlock warning and removed mutex_{lock,unlock} of fs_info::tree_root->log_mutex.
While it looks like it always cause a deadlock, we didn't see actual
deadlock in fstests runs. The reason is log_root_tree->log_mutex !=
fs_info->tree_root->log_mutex, not taking the same lock. So, the warning
was actually a false-positive.
Since btrfs_alloc_log_tree_node() is protected only by
fs_info->tree_root->log_mutex, we can (and should) move the code out of
the lock scope of log_root_tree->log_mutex and silence the warning.
Fixes: 6e37d2459941 ("btrfs: zoned: fix deadlock on log sync")
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'lib/test_bits.c')
0 files changed, 0 insertions, 0 deletions