diff options
| author | Nikolay Aleksandrov <nikolay@cumulusnetworks.com> | 2017-02-04 18:05:07 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-02-06 22:53:13 -0500 |
| commit | f7cdee8a79a1cb03fa9ca71b825e72f880b344e1 (patch) | |
| tree | bda0a6e29e0d7748d2f7e59a8da9c5194f486b36 /net/bridge/br_stp_timer.c | |
| parent | 1f90c7f3470580e24da25f6a6c1fb480ed9371ac (diff) | |
bridge: move to workqueue gc
Move the fdb garbage collector to a workqueue which fires at least 10
milliseconds apart and cleans chain by chain allowing for other tasks
to run in the meantime. When having thousands of fdbs the system is much
more responsive. Most importantly remove the need to check if the
matched entry has expired in __br_fdb_get that causes false-sharing and
is completely unnecessary if we cleanup entries, at worst we'll get 10ms
of traffic for that entry before it gets deleted.
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge/br_stp_timer.c')
| -rw-r--r-- | net/bridge/br_stp_timer.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/bridge/br_stp_timer.c b/net/bridge/br_stp_timer.c index 7ddb38e0a06e..c98b3e5c140a 100644 --- a/net/bridge/br_stp_timer.c +++ b/net/bridge/br_stp_timer.c @@ -153,8 +153,6 @@ void br_stp_timer_init(struct net_bridge *br) setup_timer(&br->topology_change_timer, br_topology_change_timer_expired, (unsigned long) br); - - setup_timer(&br->gc_timer, br_fdb_cleanup, (unsigned long) br); } void br_stp_port_timer_init(struct net_bridge_port *p) |