diff options
author | Eric Dumazet <edumazet@google.com> | 2023-03-28 23:50:18 +0000 |
---|---|---|
committer | Paolo Abeni <pabeni@redhat.com> | 2023-03-30 13:40:00 +0200 |
commit | 8fcb76b934daff12cde76adeab3d502eeb0734b1 (patch) | |
tree | 4598d5acce256d5a0e045745d3f6c4947dbe611a /net/core/dev.c | |
parent | 7079d5e61aaa14cd04fd2fe7a8a2b6eca7833fdb (diff) |
net: napi_schedule_rps() cleanup
napi_schedule_rps() return value is ignored, remove it.
Change the comment to clarify the intent.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
Tested-by: Jason Xing <kerneljasonxing@gmail.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'net/core/dev.c')
-rw-r--r-- | net/core/dev.c | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 7172334a418f..f7050b95d125 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -4582,11 +4582,18 @@ static void trigger_rx_softirq(void *data) } /* - * Check if this softnet_data structure is another cpu one - * If yes, queue it to our IPI list and return 1 - * If no, return 0 + * After we queued a packet into sd->input_pkt_queue, + * we need to make sure this queue is serviced soon. + * + * - If this is another cpu queue, link it to our rps_ipi_list, + * and make sure we will process rps_ipi_list from net_rx_action(). + * As we do not know yet if we are called from net_rx_action(), + * we have to raise NET_RX_SOFTIRQ. This might change in the future. + * + * - If this is our own queue, NAPI schedule our backlog. + * Note that this also raises NET_RX_SOFTIRQ. */ -static int napi_schedule_rps(struct softnet_data *sd) +static void napi_schedule_rps(struct softnet_data *sd) { struct softnet_data *mysd = this_cpu_ptr(&softnet_data); @@ -4596,11 +4603,10 @@ static int napi_schedule_rps(struct softnet_data *sd) mysd->rps_ipi_list = sd; __raise_softirq_irqoff(NET_RX_SOFTIRQ); - return 1; + return; } #endif /* CONFIG_RPS */ __napi_schedule_irqoff(&mysd->backlog); - return 0; } #ifdef CONFIG_NET_FLOW_LIMIT |