summaryrefslogtreecommitdiff
path: root/net/devlink
diff options
context:
space:
mode:
authorJames Hershaw <james.hershaw@corigine.com>2023-02-06 16:48:36 +0100
committerJakub Kicinski <kuba@kernel.org>2023-02-07 20:20:37 -0800
commitf817554786ddc75e0960ea542061fc43a1f2f7e2 (patch)
tree1067b604576f85faa6200270bbcd9fff0efb38ef /net/devlink
parentb24e9de39880e700f9a6ea9b5d33bb0d81e9cf81 (diff)
nfp: flower: add check for flower VF netdevs for get/set_eeprom
Move the nfp_net_get_port_mac_by_hwinfo() check to ahead in the get/set_eeprom() functions to in order to check for a VF netdev, which this function does not support. It is debatable if this is a fix or an enhancement, and we have chosen to go for the latter. It does address a problem introduced by commit 74b4f1739d4e ("nfp: flower: change get/set_eeprom logic and enable for flower reps"). However, the ethtool->len == 0 check avoids the problem manifesting as a run-time bug (NULL pointer dereference of app). Signed-off-by: James Hershaw <james.hershaw@corigine.com> Reviewed-by: Louis Peens <louis.peens@corigine.com> Signed-off-by: Simon Horman <simon.horman@corigine.com> Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Link: https://lore.kernel.org/r/20230206154836.2803995-1-simon.horman@corigine.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/devlink')
0 files changed, 0 insertions, 0 deletions