diff options
| author | Florian Fainelli <f.fainelli@gmail.com> | 2017-04-08 08:55:22 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-04-08 13:49:36 -0700 |
| commit | 16c5dcb13a371feae0e680e6518775b5335b37d8 (patch) | |
| tree | 2dd0fe414dc67bcef0da6c4e2a19178650145fe3 /net/dsa/tag_dsa.c | |
| parent | 9d7f9c4f78e95dd9d17199a53d903262530be62e (diff) | |
net: dsa: Move skb_unshare() to dsa_switch_rcv()
All DSA tag receive functions need to unshare the skb before mangling it, move
this to the generic dsa_switch_rcv() function which will allow us to make the
tag receive function return their mangled skb without caring about freeing a
NULL skb.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa/tag_dsa.c')
| -rw-r--r-- | net/dsa/tag_dsa.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/net/dsa/tag_dsa.c b/net/dsa/tag_dsa.c index 377569c0e4f7..b7032699eaad 100644 --- a/net/dsa/tag_dsa.c +++ b/net/dsa/tag_dsa.c @@ -77,10 +77,6 @@ static int dsa_rcv(struct sk_buff *skb, struct net_device *dev, int source_device; int source_port; - skb = skb_unshare(skb, GFP_ATOMIC); - if (skb == NULL) - goto out; - if (unlikely(!pskb_may_pull(skb, DSA_HLEN))) goto out_drop; @@ -175,7 +171,6 @@ static int dsa_rcv(struct sk_buff *skb, struct net_device *dev, out_drop: kfree_skb(skb); -out: return 0; } |