diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2024-05-23 12:28:01 -0700 | 
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2024-05-23 12:28:01 -0700 | 
| commit | d6a326d694e77fd1d90ae40ad3c73a6af0eb1b8d (patch) | |
| tree | 65620f42b46c745e16298f31b45d54b33ec0ebea /net/openvswitch/openvswitch_trace.h | |
| parent | bca2a25d3be779fbdf912de8e1ded6dcd483845d (diff) | |
| parent | 2c92ca849fcc6ee7d0c358e9959abc9f58661aea (diff) | |
Merge tag 'trace-assign-str-v6.10' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace
Pull tracing cleanup from Steven Rostedt:
 "Remove second argument of __assign_str()
  The __assign_str() macro logic of the TRACE_EVENT() macro was
  optimized so that it no longer needs the second argument. The
  __assign_str() is always matched with __string() field that takes a
  field name and the source for that field:
    __string(field, source)
  The TRACE_EVENT() macro logic will save off the source value and then
  use that value to copy into the ring buffer via the __assign_str().
  Before commit c1fa617caeb0 ("tracing: Rework __assign_str() and
  __string() to not duplicate getting the string"), the __assign_str()
  needed the second argument which would perform the same logic as the
  __string() source parameter did. Not only would this add overhead, but
  it was error prone as if the __assign_str() source produced something
  different, it may not have allocated enough for the string in the ring
  buffer (as the __string() source was used to determine how much to
  allocate)
  Now that the __assign_str() just uses the same string that was used in
  __string() it no longer needs the source parameter. It can now be
  removed"
* tag 'trace-assign-str-v6.10' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace:
  tracing/treewide: Remove second parameter of __assign_str()
Diffstat (limited to 'net/openvswitch/openvswitch_trace.h')
| -rw-r--r-- | net/openvswitch/openvswitch_trace.h | 8 | 
1 files changed, 4 insertions, 4 deletions
diff --git a/net/openvswitch/openvswitch_trace.h b/net/openvswitch/openvswitch_trace.h index 3eb35d9eb700..74d75aaebef4 100644 --- a/net/openvswitch/openvswitch_trace.h +++ b/net/openvswitch/openvswitch_trace.h @@ -43,8 +43,8 @@ TRACE_EVENT(ovs_do_execute_action,  	TP_fast_assign(  		__entry->dpaddr = dp; -		__assign_str(dp_name, ovs_dp_name(dp)); -		__assign_str(dev_name, skb->dev->name); +		__assign_str(dp_name); +		__assign_str(dev_name);  		__entry->skbaddr = skb;  		__entry->len = skb->len;  		__entry->data_len = skb->data_len; @@ -113,8 +113,8 @@ TRACE_EVENT(ovs_dp_upcall,  	TP_fast_assign(  		__entry->dpaddr = dp; -		__assign_str(dp_name, ovs_dp_name(dp)); -		__assign_str(dev_name, skb->dev->name); +		__assign_str(dp_name); +		__assign_str(dev_name);  		__entry->skbaddr = skb;  		__entry->len = skb->len;  		__entry->data_len = skb->data_len;  | 
