summaryrefslogtreecommitdiff
path: root/net/phonet
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2024-05-02 16:17:00 +0000
committerJakub Kicinski <kuba@kernel.org>2024-05-06 18:30:00 -0700
commitd8cac8568618dcb8a51af3db1103e8d4cc4aeea7 (patch)
tree96fa50da9c6f58844cef5991d32cea9da4f99bfd /net/phonet
parenta26ff37e624d12e28077e5b24d2b264f62764ad6 (diff)
phonet: fix rtm_phonet_notify() skb allocation
fill_route() stores three components in the skb: - struct rtmsg - RTA_DST (u8) - RTA_OIF (u32) Therefore, rtm_phonet_notify() should use NLMSG_ALIGN(sizeof(struct rtmsg)) + nla_total_size(1) + nla_total_size(4) Fixes: f062f41d0657 ("Phonet: routing table Netlink interface") Signed-off-by: Eric Dumazet <edumazet@google.com> Acked-by: RĂ©mi Denis-Courmont <courmisch@gmail.com> Link: https://lore.kernel.org/r/20240502161700.1804476-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/phonet')
-rw-r--r--net/phonet/pn_netlink.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/phonet/pn_netlink.c b/net/phonet/pn_netlink.c
index 59aebe296890..dd4c7e9a634f 100644
--- a/net/phonet/pn_netlink.c
+++ b/net/phonet/pn_netlink.c
@@ -193,7 +193,7 @@ void rtm_phonet_notify(int event, struct net_device *dev, u8 dst)
struct sk_buff *skb;
int err = -ENOBUFS;
- skb = nlmsg_new(NLMSG_ALIGN(sizeof(struct ifaddrmsg)) +
+ skb = nlmsg_new(NLMSG_ALIGN(sizeof(struct rtmsg)) +
nla_total_size(1) + nla_total_size(4), GFP_KERNEL);
if (skb == NULL)
goto errout;