diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2024-05-23 12:28:01 -0700 | 
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2024-05-23 12:28:01 -0700 | 
| commit | d6a326d694e77fd1d90ae40ad3c73a6af0eb1b8d (patch) | |
| tree | 65620f42b46c745e16298f31b45d54b33ec0ebea /net/tipc | |
| parent | bca2a25d3be779fbdf912de8e1ded6dcd483845d (diff) | |
| parent | 2c92ca849fcc6ee7d0c358e9959abc9f58661aea (diff) | |
Merge tag 'trace-assign-str-v6.10' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace
Pull tracing cleanup from Steven Rostedt:
 "Remove second argument of __assign_str()
  The __assign_str() macro logic of the TRACE_EVENT() macro was
  optimized so that it no longer needs the second argument. The
  __assign_str() is always matched with __string() field that takes a
  field name and the source for that field:
    __string(field, source)
  The TRACE_EVENT() macro logic will save off the source value and then
  use that value to copy into the ring buffer via the __assign_str().
  Before commit c1fa617caeb0 ("tracing: Rework __assign_str() and
  __string() to not duplicate getting the string"), the __assign_str()
  needed the second argument which would perform the same logic as the
  __string() source parameter did. Not only would this add overhead, but
  it was error prone as if the __assign_str() source produced something
  different, it may not have allocated enough for the string in the ring
  buffer (as the __string() source was used to determine how much to
  allocate)
  Now that the __assign_str() just uses the same string that was used in
  __string() it no longer needs the source parameter. It can now be
  removed"
* tag 'trace-assign-str-v6.10' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace:
  tracing/treewide: Remove second parameter of __assign_str()
Diffstat (limited to 'net/tipc')
| -rw-r--r-- | net/tipc/trace.h | 16 | 
1 files changed, 8 insertions, 8 deletions
diff --git a/net/tipc/trace.h b/net/tipc/trace.h index 04af83f0500c..865142ed0ab4 100644 --- a/net/tipc/trace.h +++ b/net/tipc/trace.h @@ -145,7 +145,7 @@ DECLARE_EVENT_CLASS(tipc_skb_class,  	),  	TP_fast_assign( -		__assign_str(header, header); +		__assign_str(header);  		tipc_skb_dump(skb, more, __get_str(buf));  	), @@ -172,7 +172,7 @@ DECLARE_EVENT_CLASS(tipc_list_class,  	),  	TP_fast_assign( -		__assign_str(header, header); +		__assign_str(header);  		tipc_list_dump(list, more, __get_str(buf));  	), @@ -200,7 +200,7 @@ DECLARE_EVENT_CLASS(tipc_sk_class,  	),  	TP_fast_assign( -		__assign_str(header, header); +		__assign_str(header);  		__entry->portid = tipc_sock_get_portid(sk);  		tipc_sk_dump(sk, dqueues, __get_str(buf));  		if (skb) @@ -254,7 +254,7 @@ DECLARE_EVENT_CLASS(tipc_link_class,  	),  	TP_fast_assign( -		__assign_str(header, header); +		__assign_str(header);  		memcpy(__entry->name, tipc_link_name(l), TIPC_MAX_LINK_NAME);  		tipc_link_dump(l, dqueues, __get_str(buf));  	), @@ -337,7 +337,7 @@ DECLARE_EVENT_CLASS(tipc_node_class,  	),  	TP_fast_assign( -		__assign_str(header, header); +		__assign_str(header);  		__entry->addr = tipc_node_get_addr(n);  		tipc_node_dump(n, more, __get_str(buf));  	), @@ -374,7 +374,7 @@ DECLARE_EVENT_CLASS(tipc_fsm_class,  	),  	TP_fast_assign( -		__assign_str(name, name); +		__assign_str(name);  		__entry->os = os;  		__entry->ns = ns;  		__entry->evt = evt; @@ -409,8 +409,8 @@ TRACE_EVENT(tipc_l2_device_event,  	),  	TP_fast_assign( -		__assign_str(dev_name, dev->name); -		__assign_str(b_name, b->name); +		__assign_str(dev_name); +		__assign_str(b_name);  		__entry->evt = evt;  		__entry->b_up = test_bit(0, &b->up);  		__entry->carrier = netif_carrier_ok(dev);  | 
