diff options
author | Darrick J. Wong <darrick.wong@oracle.com> | 2020-11-19 15:17:50 -0800 |
---|---|---|
committer | Darrick J. Wong <darrick.wong@oracle.com> | 2020-11-19 15:17:50 -0800 |
commit | eb8409071a1d47e3593cfe077107ac46853182ab (patch) | |
tree | 300ec60cd9ad8fbf93fda120d3fb3e5b10b1e43e /scripts/mod | |
parent | 883a790a84401f6f55992887fd7263d808d4d05d (diff) |
xfs: revert "xfs: fix rmap key and record comparison functions"
This reverts commit 6ff646b2ceb0eec916101877f38da0b73e3a5b7f.
Your maintainer committed a major braino in the rmap code by adding the
attr fork, bmbt, and unwritten extent usage bits into rmap record key
comparisons. While XFS uses the usage bits *in the rmap records* for
cross-referencing metadata in xfs_scrub and xfs_repair, it only needs
the owner and offset information to distinguish between reverse mappings
of the same physical extent into the data fork of a file at multiple
offsets. The other bits are not important for key comparisons for index
lookups, and never have been.
Eric Sandeen reports that this causes regressions in generic/299, so
undo this patch before it does more damage.
Reported-by: Eric Sandeen <sandeen@sandeen.net>
Fixes: 6ff646b2ceb0 ("xfs: fix rmap key and record comparison functions")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Diffstat (limited to 'scripts/mod')
0 files changed, 0 insertions, 0 deletions