diff options
| author | Murad Masimov <m.masimov@maxima.ru> | 2024-10-01 22:08:39 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-10-02 14:02:32 +0100 |
| commit | 8cd4e1f087b6906bacbbf8b637cac4e479a9cb34 (patch) | |
| tree | 44f3ccb009bffa53c52528cc7e866e5757821aee /sound/soc/amd | |
| parent | 436bf27903ee56a242bcd373053dd8d1b5d17915 (diff) | |
ASoC: amd: acp: drop bogus NULL check from i2s_irq_handler
When i2s_irq_handler is called, it's guaranteed that adata is not NULL,
since IRQ handlers are guaranteed to be provided with a valid data pointer.
Moreover, adata pointer is being dereferenced right before the NULL check,
which makes the check pointless, even if adata could be NULL.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Murad Masimov <m.masimov@maxima.ru>
Link: https://patch.msgid.link/20241001190848.711-1-m.masimov@maxima.ru
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/amd')
| -rw-r--r-- | sound/soc/amd/acp/acp-platform.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c index 7be9b4ff7923..1f352b2b3002 100644 --- a/sound/soc/amd/acp/acp-platform.c +++ b/sound/soc/amd/acp/acp-platform.c @@ -143,9 +143,6 @@ static irqreturn_t i2s_irq_handler(int irq, void *data) u16 i2s_flag = 0; u32 ext_intr_stat, ext_intr_stat1; - if (!adata) - return IRQ_NONE; - if (adata->rsrc->no_of_ctrls == 2) ext_intr_stat1 = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1))); |