diff options
author | Ming Lei <ming.lei@redhat.com> | 2024-12-06 19:16:07 +0800 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2024-12-06 09:48:46 -0700 |
commit | 22465bbac53c821319089016f268a2437de9b00a (patch) | |
tree | ede441a86ad12f66b693f6852bbe6225776efe98 /tools/perf/tests/shell/lib/perf_json_output_lint.py | |
parent | 4bf485a7db5d82ddd0f3ad2b299893199090375e (diff) |
blk-mq: move cpuhp callback registering out of q->sysfs_lock
Registering and unregistering cpuhp callback requires global cpu hotplug lock,
which is used everywhere. Meantime q->sysfs_lock is used in block layer
almost everywhere.
It is easy to trigger lockdep warning[1] by connecting the two locks.
Fix the warning by moving blk-mq's cpuhp callback registering out of
q->sysfs_lock. Add one dedicated global lock for covering registering &
unregistering hctx's cpuhp, and it is safe to do so because hctx is
guaranteed to be live if our request_queue is live.
[1] https://lore.kernel.org/lkml/Z04pz3AlvI4o0Mr8@agluck-desk3/
Cc: Reinette Chatre <reinette.chatre@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Peter Newman <peternewman@google.com>
Cc: Babu Moger <babu.moger@amd.com>
Reported-by: Luck Tony <tony.luck@intel.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Tested-by: Tony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/r/20241206111611.978870-3-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'tools/perf/tests/shell/lib/perf_json_output_lint.py')
0 files changed, 0 insertions, 0 deletions