diff options
| author | Andrii Nakryiko <andriin@fb.com> | 2020-02-29 15:11:11 -0800 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2020-03-02 16:25:14 -0800 |
| commit | 396f544ed5e5a9c40de5663b774f643644cba059 (patch) | |
| tree | 33208526d4177af87a61d5f2fdc6fdc521ccc8b9 /tools/testing/selftests/bpf/progs/test_attach_probe.c | |
| parent | fd56e0058412fb542db0e9556f425747cf3f8366 (diff) | |
selftests/bpf: Fix BPF_KRETPROBE macro and use it in attach_probe test
For kretprobes, there is no point in capturing input arguments from pt_regs,
as they are going to be, most probably, clobbered by the time probed kernel
function returns. So switch BPF_KRETPROBE to accept zero or one argument
(optional return result).
Fixes: ac065870d928 ("selftests/bpf: Add BPF_PROG, BPF_KPROBE, and BPF_KRETPROBE macros")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20200229231112.1240137-4-andriin@fb.com
Diffstat (limited to 'tools/testing/selftests/bpf/progs/test_attach_probe.c')
| -rw-r--r-- | tools/testing/selftests/bpf/progs/test_attach_probe.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/testing/selftests/bpf/progs/test_attach_probe.c b/tools/testing/selftests/bpf/progs/test_attach_probe.c index dd8fae6660ab..38ed8c3bf922 100644 --- a/tools/testing/selftests/bpf/progs/test_attach_probe.c +++ b/tools/testing/selftests/bpf/progs/test_attach_probe.c @@ -4,6 +4,7 @@ #include <linux/ptrace.h> #include <linux/bpf.h> #include <bpf/bpf_helpers.h> +#include "bpf_trace_helpers.h" int kprobe_res = 0; int kretprobe_res = 0; @@ -18,7 +19,7 @@ int handle_kprobe(struct pt_regs *ctx) } SEC("kretprobe/sys_nanosleep") -int handle_kretprobe(struct pt_regs *ctx) +int BPF_KRETPROBE(handle_kretprobe) { kretprobe_res = 2; return 0; |