summaryrefslogtreecommitdiff
path: root/drivers/staging/bcm/nvm.c
AgeCommit message (Collapse)Author
2014-10-20staging: bcm: remove driverJeff Kirsher
The Beceem WiMAX driver was barely function in its current state and was non-functional on 64 bit systems. Based on repeated statements from Greg KH that he wanted the driver removed, I am removing the driver. CC: Matthias Beyer <mail@beyermatthias.de> CC: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-23Staging: bcm: nvm.c: Don't pass the indexMatthias Beyer
The variable 'i' does not need to be passed, as we set it to 0 (zero) anyways when starting the iteration here. Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-23Staging: bcm: nvm.c: Fixed variable typeMatthias Beyer
The variable type of the local variable 'j' should be 'int' instead of 'unsigned int'. Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21Staging: bcm: nvm.c: replaced member accessing with variableMatthias Beyer
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21Staging: bcm: nvm.c: Removed indentation level by concatenating nested if ↵Matthias Beyer
statements Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21Staging: bcm: nvm.c: Removed indentation level by using continue statementMatthias Beyer
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21Staging: bcm: nvm.c: Outsourced chunk of code into functionMatthias Beyer
This patch outsources a chunk of code into an own function. It also refactors the variable names which are used within this function. The function name may be not appropriate. Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-21Staging: bcm: nvm.c: Shortened linesMatthias Beyer
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-09staging: bcm: add missing blank lines after declarationsPawel Lebioda
Fix "Missing blank line after declaration" warnings reported by checkpatch.pl. Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26staging: bcm: nvm.c: Cleaning up check unsigned is less than zeroRickard Strandqvist
Remove checking if a unsigned int is less than zero This was found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: bcm: nvm.c: Cleaning up a array that is filled incompletelyRickard Strandqvist
Array 'SigBuff' is filled incompletely. Someone forget to multiply for the sizeof type. This was partly found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19Staging: bcm: Remove unnecessary parenthesesTugce Sirin
This patch fixes checkpatch.pl warning Unnecessary parentheses in bcm driver. Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-16Staging: bcm: Fix sparse non-static symbol warningTugce Sirin
Fix sparse non-static symbol warning in bcm driver. Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com> Acked-by: Sarah Sharp <sarah.a.sharp@linux.intel.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-01-11staging: bcm : Fix typo in staging/bcmMasanari Iida
This patch fixed spelling typo in comment and printks withing staging/bcm. Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-08drivers: bcm: Remove unused function in nvm.cRashika Kheria
Remove unused function PropagateCalParamsFromEEPROMToMemory() in nvm.c. This eliminates the following warning in nvm.c: drivers/staging/bcm/nvm.c:1369:5: warning: no previous prototype for ‘PropagateCalParamsFromEEPROMToMemory’ [-Wmissing-prototypes] Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-12-20drivers/staging/bcm: Integer overflowWenliang Fan
The checking condition in 'validateFlash2xReadWrite()' is not sufficient. A large number invalid would cause an integer overflow and pass the condition, which could cause further integer overflows in 'Bcmchar.c:bcm_char_ioctl()'. Signed-off-by: Wenliang Fan <fanwlexca@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: bcm: Replace FALSE with falseLisa Nguyen
Replace user-defined type FALSE with C defined false keyword. Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-28staging: bcm: Replace BOOLEAN with boolLisa Nguyen
Remove user-defined BOOLEAN data type with C bool data type. Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-09-17Staging: bcm: nvm: fixed space prohibitionAldo Iljazi
Fixed space prohibition before semicolon, particularly: nvm.c:106: WARNING: space prohibited before semicolon nvm.c:1098: WARNING: space prohibited before semicolon nvm.c:1279: WARNING: space prohibited before semicolon nvm.c:2834: WARNING: space prohibited before semicolon nvm.c:3361: WARNING: space prohibited before semicolon nvm.c:4453: WARNING: space prohibited before semicolon Signed-off-by: Aldo Iljazi <neonsync1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-08-23staging: bcm: Fix typo in commentsMasanari Iida
Correct spelling typo in staging/bcm Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-03-11staging: bcm: don't cast kzalloc() return valueMihnea Dobrescu-Balaur
Signed-off-by: Mihnea Dobrescu-Balaur <mihneadb@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-11Staging: bcm: add a missing break statementDan Carpenter
My static checker complains that there is a missing break statement here. From the context, it does look like a break statement was intended. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07Staging: bcm: Remove typedef for eNVM_TYPE and call directly.Kevin McKinney
This patch removes typedef for eNVM_TYPE, and changes the name of the enum to bcm_nvm_type. In addition, any calls to enum "NVM_TYPE" are changed to call directly. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07Staging: bcm: Remove typedef for _FLASH_CS_INFO and call directly.Kevin McKinney
This patch removes typedef for _FLASH_CS_INFO, and changes the name of the struct to bcm_flash_cs_info. In addition, any calls to typedefs FLASH_CS_INFO, or *PFLASH_CS_INFO are changed to call the struct directly. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07Staging: bcm: Remove typedef for _FLASH_2X_CS_INFO and call directly.Kevin McKinney
This patch removes typedef for _FLASH_2X_CS_INFO, and changes the name of the struct to bcm_flash2x_cs_info. In addition, any calls to typedefs FLASH2X_CS_INFO, or *PFLASH2X_CS_INFO are changed to call the struct directly. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07Staging: bcm: Remove typedef for _FLASH2X_VENDORSPECIFIC_INFO and call directly.Kevin McKinney
This patch removes typedef for _FLASH2X_VENDORSPECIFIC_INFO, and changes the name of the struct to bcm_flash2x_vendor_info. In addition, any calls to typedefs FLASH2X_VENDORSPECIFIC_INFO, or *PFLASH2X_VENDORSPECIFIC_INFO are changed to call the struct directly. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07Staging: bcm: Remove typedef for _DSD_HEADER and call directly.Kevin McKinney
This patch removes typedef for _DSD_HEADER, and changes the name of the struct to bcm_dsd_header. In addition, any calls to typedefs DSD_HEADER, or *PDSD_HEADER are changed to call the struct directly. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-07Staging: bcm: Remove typedef for _ISO_HEADER and call directly.Kevin McKinney
This patch removes typedef for _ISO_HEADER, and changes the name of the struct to bcm_iso_header. In addition, any calls to typedefs ISO_HEADER, or *PISO_HEADER are changed to call the struct directly. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-11-26Staging: bcm: Remove typedef for _FLASH2X_SECTION_VAL and reference directly.Kevin McKinney
This patch removes typedef for _FLASH2X_SECTION_VAL, and changes the name of the enum to bcm_flash2x_section_val. In addition, any calls to typedefs FLASH2X_SECTION_VAL are changed to reference the enum directly. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-11-26Staging: bcm: Remove typedef for _FLASH2X_READWRITE and call directly.Kevin McKinney
This patch removes typedef for _FLASH2X_READWRITE, and changes the name of the struct to bcm_flash2x_readwrite. In addition, any calls to typedefs FLASH2X_READWRITE, or *PFLASH2X_READWRITE are changed to call the struct directly. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-11-26Staging: bcm: Remove typedef for _FLASH2X_COPY_SECTION and call directly.Kevin McKinney
This patch removes typedef for _FLASH2X_COPY_SECTION, and changes the name of the struct to bcm_flash2x_copy_section. In addition, any calls to typedefs FLASH2X_COPY_SECTION, or *PFLASH2X_COPY_SECTION are changed to call the struct directly. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-11-26Staging: bcm: Remove typedef for _FLASH2X_BITMAP and call directly.Kevin McKinney
This patch removes typedef for _FLASH2X_BITMAP, and changes the name of the struct to bcm_flash2x_bitmap. In addition, any calls to typedefs FLASH2X_BITMAP, or *PFLASH2X_BITMAP are changed to call the struct directly. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-09-13Staging: bcm: Fix udelay related compilation errorTushar Behera
commit 6788d7dab6a5 ("Staging: bcm: Use udelay instead of msleep for delays in nvm.c") replaces msleep with udelay values. udelay values of more than 1000 should be replaced by mdelay instead. This fixes following build error. ERROR: "__bad_udelay" [drivers/staging/bcm/bcm_wimax.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 Cc: Kevin McKinney <klmckinney1@gmail.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Tushar Behera <tushar.behera@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-08-17staging: bcm: Fix typo in drivers/bcmMasanari Iida
Correct spelling typo in drivers/bcm Signed-off-by: Masanari Iida <standby24x7@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-20Staging: bcm: Change order in if conditions to make more readable in nvm.cKevin McKinney
This patch changes the order of several if conditions to make the code more readable. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-20Staging: bcm: Change conditions that check for NULL in nvm.cKevin McKinney
This patch changes all conditions that check for NULL from "if (variable == NULL)" or "if (NULL == variable)" to "if (variable)" to make code more readable. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-20Staging: bcm: Replace UINT with "unsigned int" in nvm.cKevin McKinney
This patch replaces all uppercase UINT with "unsigned int". Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-20Staging: bcm: Replace INT with int in nvm.cKevin McKinney
This patch replaces all uppercase INT with lowercase int. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-12Staging: bcm: Return -ENOMEM instead of -1 when memory not acquired in nmv.cKevin McKinney
This patch changes the return statement on two conditions where memory could not be acquired. It returns -ENOMEM instead of -1. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-12Staging: bcm: Use udelay instead of msleep for delays in nvm.cKevin McKinney
This patch uses udelay instead of msleep for delays because msleep can sleep up to 20ms for any value less than 20. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-12Staging: bcm: Fix ERROR: return is not a function, parentheses are not required.Kevin McKinney
This patch fixes the following error reported by checkpatch.pl in nvm.c: "ERROR: return is not a function, parentheses are not required". Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-12Staging: bcm: Correctly format all comments in nvm.cKevin McKinney
This patch correctly formats all comments as reported by checkpatch.pl. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-12Staging: bcm: Properly format braces in nvm.cKevin McKinney
This patch cuddles braces as reported by checkpatch.pl. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-12Staging: bcm: Fix all whitespace issues in nvm.cKevin McKinney
This patch resolves all whitespace issues as reported by checkpatch.pl. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-06-04Staging: bcm: Remove typedef for _MINI_ADAPTER and call directly.Kevin McKinney
This patch removes typedef for _MINI_ADAPTER, changes the name of the struct from _MINI_ADAPTER to bcm_mini_adapter. In addition, any calls to the following typedefs "MINI_ADAPTER, *PMINI_ADAPTER" are changed to call the struct directly. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2011-11-26Staging: bcm: Fix information leak in ioctl: ↵Kevin McKinney
IOCTL_BCM_REGISTER_READ_PRIVATE, IOCTL_BCM_EEPROM_REGISTER_READ This patch fixes an information leak in ioctl IOCTL_BCM_REGISTER_READ_PRIVATE and IOCTL_BCM_EEPROM_REGISTER_READ when determining the number of bytes to copy to user space. Function, usb_control_msg, returns the correct number of bytes from the hardware. Instead of using this value, we were using a value derived from user space. In this case, this value could be more than the hardware allocated. Therefore, this patch copies the proper number of bytes from the hardware, and uses this value as the maximum number of bytes for user space. Signed-off-by: Kevin McKinney <klmckinney1@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-08-23drivers/staging/bcm/nvm.c: add missing kfreeJulia Lawall
Buff is only used as a temporary buffer within the function, so it should be freed before leaving the function in an error case. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @exists@ local idexpression x; statement S,S1; expression E; identifier fl; expression *ptr != NULL; @@ x = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...kfree(x)...+> } when any when != true x == NULL x->fl ...> ( if (x == NULL) S1 | if (...) { ... when != x when forall ( return \(0\|<+...x...+>\|ptr\); | * return ...; ) } ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-31Fix common misspellingsLucas De Marchi
Fixes generated by 'codespell' and manually reviewed. Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
2010-11-01beceem: change startup messagesStephen Hemminger
Change the regsister/unregister routines to generate better messages, and control arrival of new frames when USB device is unplugged. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: make local functions staticStephen Hemminger
Use namespace tool from kernel scripts to identify dead code and functions that should be static. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
generated by cgit v1.2.3-70-g09d2 (git 2.48.1) at 2025-08-07 15:13:14 +0000