Merge pull request #285 from jwacalex/gh_issue_253_disallow_selfsignup_for_shifts

Issue #253 disallow selfsignup for shifts

5 files changed, 18 insertions, 5 deletions

diff --git a/db/update.sql b/db/update.sql
index 93f29e89..5682f1ee 100644
--- a/db/update.sql
+++ b/db/update.sql
@@ -3,4 +3,7 @@ INSERT INTO `GroupPrivileges` (`id`, `group_id`, `privilege_id`) VALUES (NULL, '
 
 ALTER TABLE `UserAngelTypes` CHANGE `coordinator` `supporter` BOOLEAN;
 
-ALTER TABLE `User` ADD COLUMN `email_by_human_allowed` BOOLEAN NOT NULL;
\ No newline at end of file
+ALTER TABLE `User` ADD COLUMN `email_by_human_allowed` BOOLEAN NOT NULL;
+
+-- No Self Sign Up for some Angel Types
+ALTER TABLE engelsystem.AngelTypes ADD no_self_signup TINYINT(1) NOT NULL;
\ No newline at end of file
diff --git a/includes/controller/angeltypes_controller.php b/includes/controller/angeltypes_controller.php
index 7af05175..cd2aa3e4 100644
--- a/includes/controller/angeltypes_controller.php
+++ b/includes/controller/angeltypes_controller.php
@@ -118,6 +118,8 @@ function angeltype_edit_controller() {
       }
       
       $angeltype['restricted'] = isset($_REQUEST['restricted']);
+      $angeltype['no_self_signup'] = isset($_REQUEST['no_self_signup']);
+
       $angeltype['requires_driver_license'] = isset($_REQUEST['requires_driver_license']);
     }
     
@@ -192,6 +194,8 @@ function angeltypes_list_controller() {
     }
     
     $angeltype['restricted'] = $angeltype['restricted'] ? glyph('lock') : '';
+    $angeltype['no_self_signup'] = $angeltype['no_self_signup'] ? '' : glyph('share');
+
     $angeltype['name'] = '<a href="' . page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'] . '">' . $angeltype['name'] . '</a>';
     
     $angeltype['actions'] = table_buttons($actions);
diff --git a/includes/model/AngelType_model.php b/includes/model/AngelType_model.php
index 34da4db7..dc26fce9 100644
--- a/includes/model/AngelType_model.php
+++ b/includes/model/AngelType_model.php
@@ -10,6 +10,7 @@ function AngelType_new() {
       'id' => null,
       'name' => "",
       'restricted' => false,
+      'no_self_signup' => false,
       'description' => '',
       'requires_driver_license' => false 
   ];
@@ -44,12 +45,13 @@ function AngelType_update($angeltype) {
       `name`='" . sql_escape($angeltype['name']) . "', 
       `restricted`=" . sql_bool($angeltype['restricted']) . ",
       `description`='" . sql_escape($angeltype['description']) . "',
-      `requires_driver_license`=" . sql_bool($angeltype['requires_driver_license']) . "
+      `requires_driver_license`=" . sql_bool($angeltype['requires_driver_license']) . ",
+      `no_self_signup`=" . sql_bool($angeltype['no_self_signup']) . "
       WHERE `id`='" . sql_escape($angeltype['id']) . "'");
   if ($result === false) {
     engelsystem_error("Unable to update angeltype.");
   }
-  engelsystem_log("Updated angeltype: " . $angeltype['name'] . ($angeltype['restricted'] ? ", restricted" : "") . ($angeltype['requires_driver_license'] ? ", requires driver license" : ""));
+  engelsystem_log("Updated angeltype: " . $angeltype['name'] . ($angeltype['restricted'] ? ", restricted" : "") . ($angeltype['no_self_signup'] ? ", no_self_signup" : "") . ($angeltype['requires_driver_license'] ? ", requires driver license" : ""));
   return $result;
 }
 
diff --git a/includes/model/Shifts_model.php b/includes/model/Shifts_model.php
index b1d4ca5e..1e1bd97d 100644
--- a/includes/model/Shifts_model.php
+++ b/includes/model/Shifts_model.php
@@ -159,14 +159,16 @@ function Shift_signup_allowed($user, $shift, $angeltype, $user_angeltype = null,
     // you cannot join if shift is full
     return new ShiftSignupState(ShiftSignupState::OCCUPIED, $free_entries);
   }
-  
+
   if ($user_angeltype == null) {
     $user_angeltype = UserAngelType_by_User_and_AngelType($user, $angeltype);
   }
   
-  if ($user_angeltype == null || ($angeltype['restricted'] == 1 && $user_angeltype != null && ! isset($user_angeltype['confirm_user_id']))) {
+  if ($user_angeltype == null || ($angeltype['no_self_signup'] == 1 && $user_angeltype != null) ||
+      ($angeltype['restricted'] == 1 && $user_angeltype != null && ! isset($user_angeltype['confirm_user_id']))) {
     // you cannot join if user is not of this angel type
     // you cannot join if you are not confirmed
+
     return new ShiftSignupState(ShiftSignupState::ANGELTYPE, $free_entries);
   }
   
diff --git a/includes/view/AngelTypes_view.php b/includes/view/AngelTypes_view.php
index 0c8a4068..ce316bb7 100644
--- a/includes/view/AngelTypes_view.php
+++ b/includes/view/AngelTypes_view.php
@@ -64,6 +64,7 @@ function AngelType_edit_view($angeltype, $supporter_mode) {
       form([
           $supporter_mode ? form_info(_("Name"), $angeltype['name']) : form_text('name', _("Name"), $angeltype['name']),
           $supporter_mode ? form_info(_("Restricted"), $angeltype['restricted'] ? _("Yes") : _("No")) : form_checkbox('restricted', _("Restricted"), $angeltype['restricted']),
+          $supporter_mode ? form_info(_("No Self Sign Up"), $angeltype['no_self_signup'] ? _("Yes") : _("No")) : form_checkbox('no_self_signup', _("No Self Sign Up"), $angeltype['no_self_signup']),
           $supporter_mode ? form_info(_("Requires driver license"), $angeltype['requires_driver_license'] ? _("Yes") : _("No")) : form_checkbox('requires_driver_license', _("Requires driver license"), $angeltype['requires_driver_license']),
           form_info("", _("Restricted angel types can only be used by an angel if enabled by a supporter (double opt-in).")),
           form_textarea('description', _("Description"), $angeltype['description']),
@@ -262,6 +263,7 @@ function AngelTypes_list_view($angeltypes, $admin_angeltypes) {
       table([
           'name' => _("Name"),
           'restricted' => glyph('lock') . _("Restricted"),
+          'no_self_signup' => glyph('share') . _("Self Sign Up Allowed"),
           'membership' => _("Membership"),
           'actions' => "" 
       ], $angeltypes)